[PATCH] D42514: [ThinLTO/gold] Write empty imports even for modules with symbols

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/include/llvm/LTO/LTO.h:218
+                                          std::string LinkedObjectsFile,
+                                          IndexWriteCallback OnWrite);
 
----------------
Document new param


================
Comment at: llvm/tools/gold/gold-plugin.cpp:897
+      // build system.
+      writeEmptyDistributedBuildOutputs(Identifier, OldPrefix, NewPrefix);
     }
----------------
Should this have been removed now?


================
Comment at: llvm/tools/llvm-lto2/llvm-lto2.cpp:245
   ThinBackend Backend;
-  if (ThinLTODistributedIndexes)
-    Backend = createWriteIndexesThinBackend("", "", true, "");
-  else
+  if (ThinLTODistributedIndexes) {
+    Backend =
----------------
I think the only change here is the addition of the braces - I assume that was from some debugging code that was since removed, so the braces and the change to this file can be removed.


https://reviews.llvm.org/D42514