[PATCH] D42514: [ThinLTO/gold] Write empty imports even for modules with symbols

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka marked an inline comment as done.
vitalybuka added inline comments.


================
Comment at: llvm/tools/gold/gold-plugin.cpp:893
+      // build system.
+      writeEmptyDistributedBuildOutputs(Identifier, OldPrefix, NewPrefix);
     }
----------------
tejohnson wrote:
> It would be good to avoid writing all these files unnecessarily (the common case). You could presumably get back from LTO::add (via addModule below) whether any module in the file had a summary (from the BitcodeLTOInfo structure in LTO::addModule).
Done, but in a little bit different way. We can just inform the caller about what was actually written. This way we can avoid having in the gold plugin the logic which checks LTO properties and decides  what should be written or skipped. 


https://reviews.llvm.org/D42514