[PATCH] D42580: [ARM] Armv8.2-A FP16 code generation (part 2/3)

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 29 07:13:21 PST 2018


SjoerdMeijer added a comment.

> I'm also concerned that this code might not be correct if it triggers on code other than
>  that generated by the calling convention lowering.

I share(d) this concern a bit. But this should be a very local, peephole optimisation: just
for function arguments and return value, and I rely on the CopyToReg and CopyFrom
for that (only those patterns matched). But for this reason it is probably better to move
this logic to functions Lower argument and return value.


https://reviews.llvm.org/D42580





More information about the llvm-commits mailing list