[PATCH] D42616: [X86] Emit 15-byte NOPs on recent AMD targets, else default to 10-byte NOPs (PR22965)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 28 09:42:53 PST 2018


spatel added a comment.

In https://reviews.llvm.org/D42616#989981, @RKSimon wrote:

> What about the 11-byte NOPs for bdver - worth doing even though we'll either need to hijack FeatureXOP or use up another feature bit?


Are we approaching a feature bit count limit? If not, I think it's better to make an explicit bit.

> Not sure on padding through prefix/imm-extension - @craig.topper @spatel any ideas? We've recently been trying harder to reduce the size of immediates.......

What's the advantage of implicit padding via immediate widening vs. actual nops? I'm not familiar with how we do the padding currently, but it should be possible to choose the padding method in whatever pass handles that transform?


Repository:
  rL LLVM

https://reviews.llvm.org/D42616





More information about the llvm-commits mailing list