[PATCH] D42551: [Debug] Add dbg.value intrinsics for PHIs created during LCSSA.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 12:00:21 PST 2018


mattd added inline comments.


================
Comment at: lib/Transforms/Utils/LCSSA.cpp:226
+        NeedDbgValues.push_back(PN);
+    insertDebugValuesForPHIs(InstBB, NeedDbgValues);
     Changed = true;
----------------
vsk wrote:
> aprantl wrote:
> > Is this the one line that is not NFC in this patch?
> Yep, everything else looks like code movement.
Tanks for the review @aprantl.  This line  is a functional change.  Previously we did not introduce dbg.values here.


https://reviews.llvm.org/D42551





More information about the llvm-commits mailing list