[PATCH] D42551: [Debug] Add dbg.value intrinsics for PHIs created during LCSSA.

Thu Jan 25 11:59:03 PST 2018

vsk added a comment.

In https://reviews.llvm.org/D42551#988319, @mattd wrote:

> Thanks  for the approval @vsk.  I do not have commit access, so I'll need someone to commit this on my behalf.  Should I remove the paranoia- check you noted?

It's OK, I'll remove the check and commit this for you.

================
Comment at: lib/Transforms/Utils/LCSSA.cpp:226
+        NeedDbgValues.push_back(PN);
+    insertDebugValuesForPHIs(InstBB, NeedDbgValues);
     Changed = true;
----------------
aprantl wrote:
> Is this the one line that is not NFC in this patch?
Yep, everything else looks like code movement.

https://reviews.llvm.org/D42551