[PATCH] D42439: [GISel]: Pattern Match helpers for MachineInstructions

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/MIPatternMatch.h:1
+//== ----- llvm/CodeGen/GlobalISel/MIPatternMatch.h --------------------- == //
+//
----------------
bogner wrote:
> IIRC someone was saying they wanted to use this outside of GISel as well. Should this be hoisted up into CodeGen rather than being part of GISel?
Yes - I think Hal mentioned that. However, there is only GISel matchers right now, and I figured (also due to the GISel Utils include in this file), we can move the file later when there's a use case for it.


================
Comment at: include/llvm/CodeGen/GlobalISel/MIPatternMatch.h:269-273
+// TODO: Some contants like 0 / +0/-0
+// TODO Support GEP
+// TODO: Support SELECT/Comparisons
+// TODO: Intrinsics
+
----------------
bogner wrote:
> Remove these comments. It'll be obvious what's missing as people start using these APIs, and people can just add things as needed.
Good point. Will remove.


https://reviews.llvm.org/D42439