[PATCH] D42439: [GISel]: Pattern Match helpers for MachineInstructions

[Justin Bogner via Phabricator via llvm-commits]

bogner accepted this revision.
bogner added a comment.
This revision is now accepted and ready to land.

I find the naming conventions for the matchers kind of weird, but I see that they're meant to be familiar to users of the IR level matcher APIs so I suppose they at least make sense. Let's get this in and start using it.



================
Comment at: include/llvm/CodeGen/GlobalISel/MIPatternMatch.h:1
+//== ----- llvm/CodeGen/GlobalISel/MIPatternMatch.h --------------------- == //
+//
----------------
IIRC someone was saying they wanted to use this outside of GISel as well. Should this be hoisted up into CodeGen rather than being part of GISel?


================
Comment at: include/llvm/CodeGen/GlobalISel/MIPatternMatch.h:269-273
+// TODO: Some contants like 0 / +0/-0
+// TODO Support GEP
+// TODO: Support SELECT/Comparisons
+// TODO: Intrinsics
+
----------------
Remove these comments. It'll be obvious what's missing as people start using these APIs, and people can just add things as needed.


https://reviews.llvm.org/D42439