[PATCH] D42471: [ARM] Fix lld crash introduced by r321154

vit9696 via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 06:19:18 PST 2018


vit9696 added a comment.

In https://reviews.llvm.org/D42471#986333, @peter.smith wrote:

> Thanks for sending the patch. What I'd like to know first is in what circumstances the synthetic section has no parent and is this expected to be possible? If it isn't expected to be possible then it would be better to fix that and not try to account for the no parent case. The implementation has changed quite a bit since I last looked so I'm not sure of the intention.
>
> Do you have a test case that you could add to your patch? For example find a case that currently faults without the patch and check that it links correctly with it. Perhaps checking that the output has no .ARM.exidx sections present.


Thanks for a quick reply. The reason why it has no parent (and crashes) is because we discard this section in our custom linker script, and do not include it anywhere.
It may be discussible whether it is fine to do, but lld should not crash regardless of that.
I could provide an example, but it is kind of obvious.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42471





More information about the llvm-commits mailing list