[PATCH] D42471: [ARM] Fix lld crash introduced by r321154

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 05:55:09 PST 2018


peter.smith added a comment.

Thanks for sending the patch. What I'd like to know first is in what circumstances the synthetic section has no parent and is this expected to be possible? If it isn't expected to be possible then it would be better to fix that and not try to account for the no parent case. The implementation has changed quite a bit since I last looked so I'm not sure of the intention.

Do you have a test case that you could add to your patch? For example find a case that currently faults without the patch and check that it links correctly with it. Perhaps checking that the output has no .ARM.exidx sections present.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42471





More information about the llvm-commits mailing list