[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 22 18:09:36 PST 2018


pcc added inline comments.


================
Comment at: libcxx/include/fstream:614
+            break;
+        }
+        if (__rt)
----------------
compnerd wrote:
> It would be nice if we could do something like:
> 
>   template <typename _CharT>
>   _CharT *ModeStringFromMode(const ios_base::openmode __mode);
As discussed on IRC, I added a comment at the top of this function.


https://reviews.llvm.org/D42225





More information about the llvm-commits mailing list