[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: libcxx/include/__config:250
 #  endif
+#  define _LIBCPP_HAS_OPEN_WITH_WCHAR
 # if defined(_LIBCPP_MSVCRT)
----------------
Thanks, this is great.


================
Comment at: libcxx/include/fstream:614
+            break;
+        }
+        if (__rt)
----------------
It would be nice if we could do something like:

  template <typename _CharT>
  _CharT *ModeStringFromMode(const ios_base::openmode __mode);


https://reviews.llvm.org/D42225