[PATCH] D42337: [Dominators] Introduce DomTree verification levels

[Daniel Berlin via Phabricator via llvm-commits]

dberlin accepted this revision.
dberlin added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D42337#983023, @kuhar wrote:

> @dberlin:
>
> > I assume if we ever bothered to make the verification O(N) again using better algorithms, we'd go back to one level of verification?
>
> I think it's very unlikely that someone will implement this in the foreseeable future.


Sure, i was just asking

>   As far as I understand, this would disallow to perform any manual updates and require extra data to be sorted in the tree and the tree nodes.

That's just the current state. These things always improve :)

> But if someone implements this, it would be best to go back one verification level. And if it tells us the tree is incorrect, we could run the current full verification to get a descriptive error message telling us what exactly went wrong.

SGTM


Repository:
  rL LLVM

https://reviews.llvm.org/D42337