[PATCH] D42337: [Dominators] Introduce DomTree verification levels

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added inline comments.


================
Comment at: include/llvm/Support/GenericDomTree.h:775
+  ///             as tree construction).
+  bool verify(VerificationLevel VL = VerificationLevel::Full) const {
+    return DomTreeBuilder::Verify(*this, VL);
----------------
brzycki wrote:
> Is the Full level the same as what verify did before this patch? I'm curious how the default level was chosen.
Yes. This is to preserve behavior of the existing code.
I also expect `DT.verify()` to be used for debugging, where you don't really care how long it takes. And then if it becomes a performance issue for someone, they can explicitly request a faster (but imprecise) level.


Repository:
  rL LLVM

https://reviews.llvm.org/D42337