[PATCH] D42201: CodeGen: handle llvm.used properly for COFF

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd marked an inline comment as done.
compnerd added inline comments.


================
Comment at: test/CodeGen/X86/coff-no-dead-strip.ll:7
+ at j = weak global i32 0
+ at k = internal global i32 0
+
----------------
rnk wrote:
> Maybe test a vectorcallcc function to test that we're using the GlobalValue overload of getNameWithPrefix.
Sounds good.


================
Comment at: test/CodeGen/X86/coff-no-dead-strip.ll:13
+; CHECK-ULP: .ascii " /INCLUDE:_i"
+; CHECK-ULP: .ascii " /INCLUDE:_j"
+; CHECK-NOULP: .ascii " /INCLUDE:i"
----------------
rnk wrote:
> `CHECK-ULP-NOT: " /INCLUDE:_k"` maybe?
Hah, I forgot to adjust the commit.  I have that added and tested with and without the user label prefix.


Repository:
  rL LLVM

https://reviews.llvm.org/D42201