[PATCH] D42201: CodeGen: handle llvm.used properly for COFF

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: test/CodeGen/X86/coff-no-dead-strip.ll:7
+ at j = weak global i32 0
+ at k = internal global i32 0
+
----------------
Maybe test a vectorcallcc function to test that we're using the GlobalValue overload of getNameWithPrefix.


================
Comment at: test/CodeGen/X86/coff-no-dead-strip.ll:13
+; CHECK-ULP: .ascii " /INCLUDE:_i"
+; CHECK-ULP: .ascii " /INCLUDE:_j"
+; CHECK-NOULP: .ascii " /INCLUDE:i"
----------------
`CHECK-ULP-NOT: " /INCLUDE:_k"` maybe?


Repository:
  rL LLVM

https://reviews.llvm.org/D42201