[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

[Marshall Clow via Phabricator via llvm-commits]

mclow.lists added a comment.

In https://reviews.llvm.org/D42225#982057, @compnerd wrote:

> Can we avoid the `_WIN32` usage please?  We spent some effort to avoid it, and have `_LIBCPP_WIN32API` to indicate that we want the Win32 API.  I know that Marshall had some strong opinions on avoiding the `_WIN32` usage, but, beyond that, I think that this is a completely reasonable thing to provide.


I agree.  `_WIN32` is really a big hammer.  I'd much rather some more focused and descriptive guard macro. Maybe `_LIBCPP_HAS_OPEN_WITH_WCHAR`.

Also, if the tests are for a libc++ extension, then they belong in the test/libcxx hierarchy.


https://reviews.llvm.org/D42225