[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added a comment.

Can we avoid the `_WIN32` usage please?  We spent some effort to avoid it, and have `_LIBCPP_WIN32API` to indicate that we want the Win32 API.  I know that Marshall had some strong opinions on avoiding the `_WIN32` usage, but, beyond that, I think that this is a completely reasonable thing to provide.  I'm still torn if we should enable this on not `_LIBCPP_ABI_MICROSOFT`.  One other option would be to have a `_LIBCPP_MS_EXTENSIONS` flag to control whether they are provided.  But, all of that is merely details on how to control access to the interfaces, not the direction itself.



================
Comment at: libcxx/include/fstream:560
+basic_filebuf<_CharT, _Traits>*
+basic_filebuf<_CharT, _Traits>::open(const wchar_t* __s, ios_base::openmode __mode)
+{
----------------
Should this also be marked `inline`?


https://reviews.llvm.org/D42225