[PATCH] D42279: [WebAssembly] Don't duplicate strings in SYM_INFO subsection

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

In https://reviews.llvm.org/D42279#981492, @ncw wrote:

> Oh, having seen the LLD changes I'm torn about whether it's good to land this one first or not.
>
> What it really comes down to is: are you planning to land #5 or not? All the other changes are based around #5, and if that one doesn't go in, I'll be sad, because it's really the main change I'm trying to achieve to with the whole patch chain. Having a single unique index per Symbol, and a single unique import/export per Symbol actually enables these changes to refer to Symbols by index.
>
> Unless you are planning to land #5 subsequently (or something else that does the same job), I'd be uneasy landing #6 at all - personally.


I'm still not sure about landing #5.   The goal of this patch was to address issue 30 but it should also make you #5 patch simply perhaps?

Not that I think about it though, maybe it time to create a prototype of my "full symbol table" idea so that it can be compared the #5 change.

Perhaps landing this breaking change in the interim is not such a good idea.


Repository:
  rL LLVM

https://reviews.llvm.org/D42279