[PATCH] D42279: [WebAssembly] Don't duplicate strings in SYM_INFO subsection

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added a comment.

Oh, having seen the LLD changes I'm torn about whether it's good to land this one first or not.

What it really comes down to is: are you planning to land #5 or not? All the other changes are based around #5, and if that one doesn't go in, I'll be sad, because it's really the main change I'm trying to achieve to with the whole patch chain. Having a single unique index per Symbol, and a single unique import/export per Symbol actually enables these changes to refer to Symbols by index.

Unless you are planning to land #5 subsequently (or something else that does the same job), I'd be uneasy landing #6 at all - personally.


Repository:
  rL LLVM

https://reviews.llvm.org/D42279