[PATCH] D42222: [llvm-objcopy] Refactor llvm-objcopy to use reader and writer objects

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich updated this revision to Diff 130507.
jakehehrlich added a comment.

1. Fixed BufPtr duplication in Writers
2. Moved Writer class to below SectionWriter
3. Removed using namespace object in favor of using specific types
4. Removed protected members (made them private)
5. Move SectionVisitor destructor to above the first SectionWriter call
6. Removed curly braces on if-stmt for WhiteSectionHeaders
7. Put code for SplitDWOToFile back in a function
8. Removed unused variable for section return
9. Removed TODO, whoops


Repository:
  rL LLVM

https://reviews.llvm.org/D42222

Files:
  test/tools/llvm-objcopy/remove-shstrtab-error.test
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h
  tools/llvm-objcopy/llvm-objcopy.cpp
  tools/llvm-objcopy/llvm-objcopy.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42222.130507.patch
Type: text/x-patch
Size: 58276 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180118/25dd4dbc/attachment.bin>