[PATCH] D42222: [llvm-objcopy] Refactor llvm-objcopy to use reader and writer objects

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 14:47:04 PST 2018


jakehehrlich added a comment.

> As to how to split it up, could the SectionWriter/SectionVisitor related changes be done first? After that a logical split would be to do the Reader-related classes, then the Writer classes, if it's possible without having to make too many intermediate changes that are just going to be thrown away.

I'll look into that. I think the SectionWriter/SectionVisitor split is very doable and should be done without question. The Reader and Writer split was the split I was thinking of initially (I was grouping the SectionVisitor split as being a part of the Writer split). I think I'm just going to have to try that one and see what happens as I don't have a good intuition for how hard that split would be.


Repository:
  rL LLVM

https://reviews.llvm.org/D42222





More information about the llvm-commits mailing list