[PATCH] D40146: [JumpThreading] Preservation of DT and LVI across the pass

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D40146#981028, @kuhar wrote:

> In https://reviews.llvm.org/D40146#981017, @MatzeB wrote:
>
> > That said it's sad to not being able to compile the llvm test-suite with expensive checks enabled (in 60min at least)...
>
>
> What kind of machine are you using and how many threads do you allow it to create to run the test suite?


That build was on a Core i5, 4 Cores @ 3.4Ghz with ninja spawning 6 clang processes (crosscompiling to aarch64).

Some files like sqlite3.c felt like they would never finish...

> 
> 
>>> @dannyb
>> 
>> It's possible to make the verification O(N) but it's algorithmically incredibly complicated :)
> 
> Alternatively, we could make `DT.verify()` only run sibling property check when `-verify-dom-info` is set, and make it incomplete but O(N^2) with just EXPENSIVE_CHECKS.  In my experience 99% of DT problems are caught in parent property check, so maybe that would be good enough?

I can't speak about the differences, but if the verifier is so slow that people will never finish the test-suite with expensive checks, then we won't catch problems there either...


Repository:
  rL LLVM

https://reviews.llvm.org/D40146