[PATCH] D40146: [JumpThreading] Preservation of DT and LVI across the pass

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 15:23:37 PST 2018


kuhar added a comment.

In https://reviews.llvm.org/D40146#981017, @MatzeB wrote:

> That said it's sad to not being able to compile the llvm test-suite with expensive checks enabled (in 60min at least)...


What kind of machine are you using and how many threads do you allow it to create to run the test suite?

>> @dannyb
> 
> It's possible to make the verification O(N) but it's algorithmically incredibly complicated :)

Alternatively, we could make `DT.verify()` only run sibling property check when `-verify-dom-info` is set, and make it incomplete but O(N^2) with just EXPENSIVE_CHECKS.  In my experience 99% of DT problems are caught in parent property check, so maybe that would be good enough?


Repository:
  rL LLVM

https://reviews.llvm.org/D40146





More information about the llvm-commits mailing list