[PATCH] D42055: Fallback option for colorized output when terminfo isn't available

[James Y Knight via Phabricator via llvm-commits]

jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D42055#980865, @joerg wrote:

> I completely disagree with this approach. A lot of GNU tools (including GCC) are completely broken. We shouldn't follow them. There are a lot more terminals around than just "dumb", "xterm" and "linux". It is completely non-acceptable to just assume ANSI escape sequences work. If Android doesn't ship a usable terminfo implementation, I consider that an Android bug. Wouldn't be the first portability nightmare with Android.


I completely disagree with your disagreement. Also, this is not an android issue.

Again note that Clang doesn't even _use_ the terminfo database, it just checks it to see if it has an attribute named "colors". Of course this is totally wrong if you are actually using a non-VTxxx-compatible terminal that supports colors. Which I assure you, do exist. Of course, nobody _uses_ any of these other crazy non-VTxxx terminals. (No, I don't care if you have such a paperweight sitting under your desk...) We should delete this code.

Nevertheless, the patch proposed here to add a fallback case is clearly fine, at a minimum. So, fine, let's not let a side-argument about removing useless code hold this up.


Repository:
  rL LLVM

https://reviews.llvm.org/D42055