[PATCH] D42055: Fallback option for colorized output when terminfo isn't available

Joerg Sonnenberger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 13:37:06 PST 2018


joerg added a comment.

I completely disagree with this approach. A lot of GNU tools (including GCC) are completely broken. We shouldn't follow them. There are a lot more terminals around than just "dumb", "xterm" and "linux". It is completely non-acceptable to just assume ANSI escape sequences work. If Android doesn't ship a usable terminfo implementation, I consider that an Android bug. Wouldn't be the first portability nightmare with Android.


Repository:
  rL LLVM

https://reviews.llvm.org/D42055





More information about the llvm-commits mailing list