[llvm] r322818 - Revert "Add a value_type to ArrayRef."

Clement Courbet via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 23:26:34 PST 2018


Author: courbet
Date: Wed Jan 17 23:26:34 2018
New Revision: 322818

URL: http://llvm.org/viewvc/llvm-project?rev=322818&view=rev
Log:
Revert "Add a value_type to ArrayRef."

clang OOMs on arm.

This reverts commit a272b2f2ef63f7f602c9ef4d9e10dc4eb9f00aa1.

Modified:
    llvm/trunk/include/llvm/ADT/ArrayRef.h
    llvm/trunk/unittests/ADT/ArrayRefTest.cpp

Modified: llvm/trunk/include/llvm/ADT/ArrayRef.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ArrayRef.h?rev=322818&r1=322817&r2=322818&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ADT/ArrayRef.h (original)
+++ llvm/trunk/include/llvm/ADT/ArrayRef.h Wed Jan 17 23:26:34 2018
@@ -45,7 +45,6 @@ namespace llvm {
     using const_iterator = const T *;
     using size_type = size_t;
     using reverse_iterator = std::reverse_iterator<iterator>;
-    using value_type = typename std::remove_cv<T>::type;
 
   private:
     /// The start of the array, in an external buffer.

Modified: llvm/trunk/unittests/ADT/ArrayRefTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/ArrayRefTest.cpp?rev=322818&r1=322817&r2=322818&view=diff
==============================================================================
--- llvm/trunk/unittests/ADT/ArrayRefTest.cpp (original)
+++ llvm/trunk/unittests/ADT/ArrayRefTest.cpp Wed Jan 17 23:26:34 2018
@@ -52,14 +52,6 @@ static_assert(
     "Assigning from an initializer list");
 #endif
 
-// Check Typedefs.
-static_assert(
-    std::is_same<ArrayRef<int>::value_type, int>::value,
-    "erroneous value_type");
-static_assert(
-    std::is_same<ArrayRef<const int>::value_type, int>::value,
-    "erroneous value_type");
-
 namespace {
 
 TEST(ArrayRefTest, AllocatorCopy) {




More information about the llvm-commits mailing list