[PATCH] D41895: [X86] Another attempt at support prefer-vector-width function attribute

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:16580
+    } else {
+      return DAG.getNode(X86ISD::VTRUNC, DL, VT, In);
+    }
----------------
RKSimon wrote:
> Is this right? It isn't the default option for AVX512 anymore.
I need to rebase this to use ISD::TRUNCATE is that what you meant?


================
Comment at: lib/Target/X86/X86Subtarget.cpp:260
+  if (PreferVectorWidthOverride)
+    PreferVectorWidth = PreferVectorWidthOverride;
+  else if (Prefer256Bit)
----------------
RKSimon wrote:
> Do we need to assert for a sane value here (else in X86TargetMachine.cpp)?
What do you consider a sane value? There's no bounds checking on the attribute coming in.


https://reviews.llvm.org/D41895