[PATCH] D42149: [GISel]: Refactor InstructionSelector::constrainSelectInstOperands

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 08:15:50 PST 2018


dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D42149#978627, @dsanders wrote:

> Hi Aditya,
>
> You forgot to include llvm-commits as a subscriber. Phabricator won't send the patch to the list if you add it now so you'll need to abandon this revision and create a new one.
>  <snip>
>  Other than that, this looks good to me. If you re-post the patch but including llvm-commits, I can LGTM it on-list.


Sorry, ignore that bit. You did include llvm-commits, it's just that Phabricator has moved where the subscribers are listed. They used to be just under the reviewers but now they're off to the side.

LGTM with the subject line change.


Repository:
  rL LLVM

https://reviews.llvm.org/D42149





More information about the llvm-commits mailing list