[PATCH] D42149: [GISel]: Refactor InstructionSelector::constrainSelectInstOperands

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added a comment.

Hi Aditya,

You forgot to include llvm-commits as a subscriber. Phabricator won't send the patch to the list if you add it now so you'll need to abandon this revision and create a new one.

The subject line '[GISel]: Refactor InstructionSelector::constrainSelectInstOperands' doesn't really describe what you're trying to do. It says what changed but not what effect that change has. Something like '[GISel] Make constrainSelectedInstRegOperands() available to the legalizer. NFC' would be better.

Other than that, this looks good to me. If you re-post the patch but including llvm-commits, I can LGTM it on-list.


Repository:
  rL LLVM

https://reviews.llvm.org/D42149