[PATCH] D42125: [CodeView] Allow variable names to be as long as the codeview format supports

[Brock Wyma via Phabricator via llvm-commits]

bwyma created this revision.
bwyma added reviewers: smerritt, aaboud, rnk.

Instead of reserving 0xF00 bytes for the fixed length portion of each CodeView symbol record (which is often much smaller) calculate the fixed portion of the record length to allow for the maximum string length possible.  This prevents unnecessary truncation of the symbol name.

Although you'll probably never see names this long in hand-written code, it can occur in generated source code.
If we have the space we might as well let people use it if they want.

I updated the existing long-names.ll test to also check for long variable names.


https://reviews.llvm.org/D42125

Files:
  lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  test/DebugInfo/COFF/long-name.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42125.130012.patch
Type: text/x-patch
Size: 132617 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180116/8c2133ab/attachment.bin>