[llvm] r322594 - [ExecutionEngine] Rename JITSymbol::isStrongDefinition to isStrong.

[Lang Hames via llvm-commits]

Author: lhames
Date: Tue Jan 16 12:39:51 2018
New Revision: 322594

URL: http://llvm.org/viewvc/llvm-project?rev=322594&view=rev
Log:
[ExecutionEngine] Rename JITSymbol::isStrongDefinition to isStrong.

For symmetry with isWeak, isCommon.

Modified:
    llvm/trunk/include/llvm/ExecutionEngine/JITSymbol.h
    llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp
    llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp

Modified: llvm/trunk/include/llvm/ExecutionEngine/JITSymbol.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/JITSymbol.h?rev=322594&r1=322593&r2=322594&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ExecutionEngine/JITSymbol.h (original)
+++ llvm/trunk/include/llvm/ExecutionEngine/JITSymbol.h Tue Jan 16 12:39:51 2018
@@ -89,7 +89,7 @@ public:
   }
 
   /// @brief Returns true if the symbol isn't weak or common.
-  bool isStrongDefinition() const {
+  bool isStrong() const {
     return !isWeak() && !isCommon();
   }
 

Modified: llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp?rev=322594&r1=322593&r2=322594&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp (original)
+++ llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp Tue Jan 16 12:39:51 2018
@@ -190,13 +190,13 @@ VSO::RelativeLinkageStrength VSO::compar
   if (Old == None)
     return llvm::orc::VSO::NewDefinitionIsStronger;
 
-  if (Old->isStrongDefinition()) {
-    if (New.isStrongDefinition())
+  if (Old->isStrong()) {
+    if (New.isStrong())
       return llvm::orc::VSO::DuplicateDefinition;
     else
       return llvm::orc::VSO::ExistingDefinitionIsStronger;
   } else {
-    if (New.isStrongDefinition())
+    if (New.isStrong())
       return llvm::orc::VSO::NewDefinitionIsStronger;
     else
       return llvm::orc::VSO::ExistingDefinitionIsStronger;

Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp?rev=322594&r1=322593&r2=322594&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp (original)
+++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp Tue Jan 16 12:39:51 2018
@@ -247,7 +247,7 @@ RuntimeDyldImpl::loadObjectImpl(const ob
         // Then check the symbol resolver to see if there's a definition
         // elsewhere in this logical dylib.
         if (auto Sym = Resolver.findSymbolInLogicalDylib(Name)) {
-          if (Sym.getFlags().isStrongDefinition())
+          if (Sym.getFlags().isStrong())
             continue;
         } else if (auto Err = Sym.takeError())
           return std::move(Err);