[PATCH] D41915: [lldCOFF] Print detailed timing information with /VERBOSE

[Zachary Turner via llvm-commits]

 I personally kind of prefer the total on the bottom, because that is a
more natural position for a total when displaying summed data. msvc linker
also prints the total at the bottom, if it matters
On Fri, Jan 12, 2018 at 5:09 PM Rui Ueyama via Phabricator <
reviews at reviews.llvm.org> wrote:

> ruiu added a comment.
>
> I tried to run this patch and found that printing out the timer tree as a
> tree  like this
>
>   Total Link Time:              (100.00%)  6470 ms
>     Input File Reading:         (  0.00%)     0 ms
>     ICF:                        (  0.00%)     0 ms
>     GC:                         (  0.00%)     0 ms
>     LTO:                        (  0.00%)     0 ms
>     Code Layout:                (  0.00%)     0 ms
>     Commit Output File:         (  0.00%)     0 ms
>     PDB Emission (Cumulative):  (  0.00%)     0 ms
>       Add Objects:              (  0.00%)     0 ms
>         Type Merging:           (  0.00%)     0 ms
>         Symbol Merging:         (  0.00%)     0 ms
>     ...
>
> is more natural than the current format
>
>     Input File Reading:         (  0.00%)     0 ms
>     ICF:                        (  0.00%)     0 ms
>     GC:                         (  0.00%)     0 ms
>     LTO:                        (  0.00%)     0 ms
>     Code Layout:                (  0.00%)     0 ms
>     Commit Output File:         (  0.00%)     0 ms
>     PDB Emission (Cumulative):  (  0.00%)     0 ms
>       Add Objects:              (  0.00%)     0 ms
>         Type Merging:           (  0.00%)     0 ms
>         Symbol Merging:         (  0.00%)     0 ms
>     ...
>   -------------------------------------------------
>   Total Link Time:              (100.00%)  6470 ms
>
> which handles only the root timer in a special way because the former
> represents a tree as-is. Do you mind if I ask you to change the format?
>
>
> https://reviews.llvm.org/D41915
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180113/4bb7996a/attachment.html>