I personally kind of prefer the total on the bottom, because that is a more natural position for a total when displaying summed data. msvc linker also prints the total at the bottom, if it matters <br><div class="gmail_quote"><div dir="ltr">On Fri, Jan 12, 2018 at 5:09 PM Rui Ueyama via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ruiu added a comment.<br>
<br>
I tried to run this patch and found that printing out the timer tree as a tree like this<br>
<br>
Total Link Time: (100.00%) 6470 ms<br>
Input File Reading: ( 0.00%) 0 ms<br>
ICF: ( 0.00%) 0 ms<br>
GC: ( 0.00%) 0 ms<br>
LTO: ( 0.00%) 0 ms<br>
Code Layout: ( 0.00%) 0 ms<br>
Commit Output File: ( 0.00%) 0 ms<br>
PDB Emission (Cumulative): ( 0.00%) 0 ms<br>
Add Objects: ( 0.00%) 0 ms<br>
Type Merging: ( 0.00%) 0 ms<br>
Symbol Merging: ( 0.00%) 0 ms<br>
...<br>
<br>
is more natural than the current format<br>
<br>
Input File Reading: ( 0.00%) 0 ms<br>
ICF: ( 0.00%) 0 ms<br>
GC: ( 0.00%) 0 ms<br>
LTO: ( 0.00%) 0 ms<br>
Code Layout: ( 0.00%) 0 ms<br>
Commit Output File: ( 0.00%) 0 ms<br>
PDB Emission (Cumulative): ( 0.00%) 0 ms<br>
Add Objects: ( 0.00%) 0 ms<br>
Type Merging: ( 0.00%) 0 ms<br>
Symbol Merging: ( 0.00%) 0 ms<br>
...<br>
-------------------------------------------------<br>
Total Link Time: (100.00%) 6470 ms<br>
<br>
which handles only the root timer in a special way because the former represents a tree as-is. Do you mind if I ask you to change the format?<br>
<br>
<br>
<a href="https://reviews.llvm.org/D41915" rel="noreferrer" target="_blank">https://reviews.llvm.org/D41915</a><br>
<br>
<br>
<br>
</blockquote></div>