[PATCH] D42010: [LLD][COFF] Report error when file will exceed Windows maximum image size (4GB)

[Colden Cullen via Phabricator via llvm-commits]

colden added inline comments.


================
Comment at: tools/lld/COFF/Writer.cpp:302
+    fatal("image size (" + Twine::utohexstr(FileSize) + ") " +
+      "exceeds maximum allowable size (" + Twine::utohexstr(UINT32_MAX) + ")");
+
----------------
ruiu wrote:
> I feel printing out a file size in hexadecimal is somewhat unusual. Maybe decimal is better?
Yeah, I was kind of surprised to see the MS linker does hex. I think you're right though, I'll switch it back.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42010