[PATCH] D42010: [LLD][COFF] Report error when file will exceed Windows maximum image size (4GB)

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Generally looking fine.



================
Comment at: tools/lld/COFF/Writer.cpp:302
+    fatal("image size (" + Twine::utohexstr(FileSize) + ") " +
+      "exceeds maximum allowable size (" + Twine::utohexstr(UINT32_MAX) + ")");
+
----------------
I feel printing out a file size in hexadecimal is somewhat unusual. Maybe decimal is better?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42010