[PATCH] D41960: [Sink] Really really fix predicate in legality check

Keno Fischer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 11 13:04:11 PST 2018


loladiro accepted this revision.
loladiro added a comment.
This revision is now accepted and ready to land.

Looks good to me with the minor tweak to the test. To keep the breadcrumb for future reference, I had changed this in https://reviews.llvm.org/D33179.



================
Comment at: test/Transforms/Sink/badloadsink.ll:21
 ; CHECK-NOT: load i64, i64 *%a
-    ret i64 %x
+; CHECK-NOT: call i8* @llvm.load.relative(i8* %ptr, i32 0)
+    %y2 = ptrtoint i8* %y to i64
----------------
`i32 %off` or just get rid of the arguments entirely


Repository:
  rL LLVM

https://reviews.llvm.org/D41960





More information about the llvm-commits mailing list