[PATCH] D41960: [Sink] Really really fix predicate in legality check

[escha via Phabricator via llvm-commits]

escha created this revision.
escha added reviewers: loladiro, majnemer.

LoadInst isn't enough; we need to include intrinsics that perform loads too.

All side-effecting intrinsics and such are already covered by the isSafe check, so we just need to care about things that read from memory.


Repository:
  rL LLVM

https://reviews.llvm.org/D41960

Files:
  lib/Transforms/Scalar/Sink.cpp
  test/Transforms/Sink/badloadsink.ll


Index: test/Transforms/Sink/badloadsink.ll
===================================================================
--- test/Transforms/Sink/badloadsink.ll
+++ test/Transforms/Sink/badloadsink.ll
@@ -1,18 +1,26 @@
 ; RUN: opt < %s -basicaa -sink -S | FileCheck %s
 declare void @foo(i64 *)
-define i64 @sinkload(i1 %cmp) {
+declare i8* @llvm.load.relative.i32(i8* %ptr, i32 %offset) argmemonly nounwind readonly
+define i64 @sinkload(i1 %cmp, i8* %ptr, i32 %off) {
 ; CHECK-LABEL: @sinkload
 top:
     %a = alloca i64
 ; CHECK: call void @foo(i64* %a)
 ; CHECK-NEXT: %x = load i64, i64* %a
+; CHECK-NEXT: %y = call i8* @llvm.load.relative.i32(i8* %ptr, i32 %off)
     call void @foo(i64* %a)
     %x = load i64, i64* %a
+    %y = call i8* @llvm.load.relative.i32(i8* %ptr, i32 %off)
     br i1 %cmp, label %A, label %B
 A:
     store i64 0, i64 *%a
+    store i8 0, i8 *%ptr
     br label %B
 B:
 ; CHECK-NOT: load i64, i64 *%a
-    ret i64 %x
+; CHECK-NOT: call i8* @llvm.load.relative(i8* %ptr, i32 0)
+    %y2 = ptrtoint i8* %y to i64
+    %retval = add i64 %y2, %x
+    ret i64 %retval
 }
+
Index: lib/Transforms/Scalar/Sink.cpp
===================================================================
--- lib/Transforms/Scalar/Sink.cpp
+++ lib/Transforms/Scalar/Sink.cpp
@@ -114,7 +114,7 @@
   if (SuccToSinkTo->getUniquePredecessor() != Inst->getParent()) {
     // We cannot sink a load across a critical edge - there may be stores in
     // other code paths.
-    if (isa<LoadInst>(Inst))
+    if (Inst->mayReadFromMemory())
       return false;
 
     // We don't want to sink across a critical edge if we don't dominate the


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41960.129503.patch
Type: text/x-patch
Size: 1625 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180111/05ab5d87/attachment.bin>