[PATCH] D41403: [ELF] Fix incorrect physical address on self-referencing AT command

[Erick Reyes via llvm-commits]

Rafael,

Can you see a potential conflict between your patch and this?

https://reviews.llvm.org/D41397

I'm not sure which one would be better.

On Wed, Jan 10, 2018 at 10:00 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Erick Reyes <erickreyes at google.com> writes:
>
> > Just reviewed Rafael's patch and confirmed it also fixes the issue and
> > passes all tests on r322147.
> >
> > However, I can't tell if the change in switchTo() can have side effects
> > since this function is called in LinkerScript::assignAddresses().
>
> If you don't mind my preference would be to go with my patch for now since
> it
> avoids duplicating the alignment computation.
>
> Rui, what do you think?
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180110/d722df93/attachment.html>