[PATCH] D41403: [ELF] Fix incorrect physical address on self-referencing AT command

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 10:00:49 PST 2018


Erick Reyes <erickreyes at google.com> writes:

> Just reviewed Rafael's patch and confirmed it also fixes the issue and
> passes all tests on r322147.
>
> However, I can't tell if the change in switchTo() can have side effects
> since this function is called in LinkerScript::assignAddresses().

If you don't mind my preference would be to go with my patch for now since it
avoids duplicating the alignment computation.

Rui, what do you think?

Cheers,
Rafael


More information about the llvm-commits mailing list