[PATCH] D41651: AMDGPU: Add 32-bit constant address space

[Marek Olšák via Phabricator via llvm-commits]

mareko added a comment.

In https://reviews.llvm.org/D41651#971102, @arsenm wrote:

> This needs to update AMDGPUAliasAnalysis. Also needs more test coverage. I don't see this testing unaligned access or some of the other places it was added.


I added CONSTANT_ADDRESS_32BIT to most places that used CONSTANT_ADDRESS. I don't know whether that's necessary or not.

> This part is problematic:
>  "Only scalar loads support 32-bit pointers. An address in a VGPR will fail to compile."
>  "https://reviews.llvm.org/D41715 (amdgpu.uniform on loads) is required for enforce scalar loads in some cases."
> 
> We can't rely on metadata to be able to compile

We need to rely on metadata. VMEM loads are simply unsupported because we don't need them with the 32-bit address space. Unaligned loads are also untested and unsupported because we don't need them either.


https://reviews.llvm.org/D41651