[PATCH] D41862: [COST]Fix PR35865: Fix cost model evaluation for shuffle on X86.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 09:43:43 PST 2018


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor



================
Comment at: test/Transforms/SLPVectorizer/X86/crash_shuffle.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -slp-vectorizer < %s -S -o - -mtriple=x86_64-apple-macosx10.10.0 -mcpu=core2 | FileCheck %s
+
----------------
Rename this pr35865.ll ? Its useful not to have to goto svn log to find where a test came from (and crash_shuffle.ll isn't that useful a name....).


https://reviews.llvm.org/D41862





More information about the llvm-commits mailing list