[PATCH] D41870: [CodeGen] Don't print "pred:" and "opt:" in -debug output

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 09:26:23 PST 2018


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

I think this change make sense given that the `pred:` and `opt:` information is not actually part of the MachineOperand but of MCInstrDesc.

I agree that having the extra "pred:" and "opt:" would make understanding easier in debugging situations but I would consider that secondary and do it in a later/a separate commit. When we do this we should enhance the .mir parser so it can skip over these prefixes so that printing them stays legal syntax.

Anyway for now I think this patch is fine.


https://reviews.llvm.org/D41870





More information about the llvm-commits mailing list