[PATCH] D41870: [CodeGen] Don't print "pred:" and "opt:" in -debug output

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 09:13:23 PST 2018


thegameg created this revision.
thegameg added reviewers: MatzeB, qcolombet.
Herald added subscribers: JDevlieghere, javed.absar.

In -debug output we print "pred:" whenever a MachineOperand is a predicate operand in the instruction descriptor, and "opt:" whenever a MachineOperand is an optional def in the instruction descriptor.

In MIR we don't print it (we don't actually need to), so I think it would be less noisy to stop printing it in -debug as well.

I wonder if we shouldn't make a more verbose version of MachineInstr::print() that is adding information like this and looks a a bit more different than MIR, but keep the default version less noisy and strip it away.


https://reviews.llvm.org/D41870

Files:
  lib/CodeGen/AggressiveAntiDepBreaker.cpp
  lib/CodeGen/CriticalAntiDepBreaker.cpp
  lib/CodeGen/MachineInstr.cpp
  lib/Target/ARM/ARMBaseInstrInfo.cpp
  test/CodeGen/ARM/2011-11-14-EarlyClobber.ll
  test/CodeGen/ARM/2014-01-09-pseudo_expand_implicit_reg.ll
  test/CodeGen/ARM/Windows/vla-cpsr.ll
  test/CodeGen/ARM/misched-int-basic-thumb2.mir
  test/CodeGen/ARM/misched-int-basic.mir
  test/CodeGen/ARM/single-issue-r52.mir
  test/CodeGen/ARM/subreg-remat.ll
  test/CodeGen/Thumb2/2010-06-14-NEONCoalescer.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41870.129101.patch
Type: text/x-patch
Size: 13803 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180109/1955996e/attachment.bin>


More information about the llvm-commits mailing list