[PATCH] D41731: [llvm-objcopy] Add --add-gnu-debuglink

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 02:17:11 PST 2018


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one change.



================
Comment at: tools/llvm-objcopy/Object.h:362-363
+public:
+  // If we add this section from an internal source we can use this ctor.
+  GnuDebugLinkSection(StringRef File, StringRef Data);
+
----------------
Do you need this constructor? It's not called anywhere as far as I can see?


Repository:
  rL LLVM

https://reviews.llvm.org/D41731





More information about the llvm-commits mailing list