[PATCH] D41731: [llvm-objcopy] Add --add-gnu-debuglink

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 8 14:24:27 PST 2018


jakehehrlich updated this revision to Diff 128981.
jakehehrlich added a comment.

1. Used numeric limits max instead of a cast and bitwise hack
2. Modified comment
3. Clang formated add-gnu-debuglink
4. Updated error message to display the specific error not just the vague "could not be opened" message.


Repository:
  rL LLVM

https://reviews.llvm.org/D41731

Files:
  test/tools/llvm-objcopy/add-gnu-debuglink.test
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h
  tools/llvm-objcopy/llvm-objcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41731.128981.patch
Type: text/x-patch
Size: 6714 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180108/24614291/attachment.bin>


More information about the llvm-commits mailing list