[PATCH] D41766: [MachineCombiner] Add check for optimal pattern order.

[Matthew Simpson via Phabricator via llvm-commits]

mssimpso added a comment.

Hi Florian,

It's hard to say how useful this patch will be, but I wouldn't mind having it under EXPENSIVE_CHECKS. Have you looked at other targets other than Arm/AArch64?



================
Comment at: test/CodeGen/AArch64/aarch64-combine-fmul-fsub.mir:29-30
 # PROFITABLE-LABEL: name: f1_2s
-# PROFITABLE: %5:fpr64 = FNEGv2f32 %2
-# PROFITABLE-NEXT: FMLAv2f32 killed %5, %0, %1
+# PROFITABLE: [[R1:%[0-9]+]]:fpr64 = FNEGv2f32 %2
+# PROFITABLE-NEXT: FMLAv2f32 killed [[R1]], %0, %1
 ---
----------------
These tests don't need changing because of this patch, right? But you can go ahead and commit the test changes separately if you need to.


https://reviews.llvm.org/D41766