[PATCH] D41734: [DebugInfo][PDB] Fix too many FPM blocks being written in some cases

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 4 11:54:56 PST 2018


zturner added a comment.

So this is interesting:

https://github.com/Microsoft/microsoft-pdb/blob/master/PDB/msf/msf.cpp#L1663-L1695

Especially the part about "Mark all non-special pages free".  But then it just says `setAll();`  Maybe this backs up your theory that the first 3 pages are "special" and so they are always allocated.

Would this mean that the first byte of `FPM[0]` actually refers to `MSF.Pages[3]` - `MSF.Pages[10]`?


Repository:
  rL LLVM

https://reviews.llvm.org/D41734





More information about the llvm-commits mailing list