[PATCH] D41734: [DebugInfo][PDB] Fix too many FPM blocks being written in some cases

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 4 11:37:04 PST 2018


zturner added a comment.

In https://reviews.llvm.org/D41734#967550, @zturner wrote:

> At (4), `cpnFpm = # of bytes of fpm data needed rounded up to a multiple of pointer size and then rounded up to a multiple of block size`
>
> rounding up to a multiple of pointer size and *then* rounding up to a multiple of block size seems to be redundant, so I interpret this as just:
>
> - # of bytes of fpm data needed rounded up to a multiple of block size


Slight correction.  `cpnFpm` is the # of **pages** needed to represent `cbFpm` bytes., which should be equivalent to `divideCeil(NumBlocks, BlockSize * 8);`

Have to think about this more though, it's possible I'm wrong.


Repository:
  rL LLVM

https://reviews.llvm.org/D41734





More information about the llvm-commits mailing list