[PATCH] D41718: [lld] Correctly link S_FILESTATIC records

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 14:50:14 PST 2018


zturner added inline comments.


================
Comment at: lld/test/COFF/pdb-file-static.yaml:56
+    Subsections:
+      - !Symbols
+        Records:
----------------
rnk wrote:
> Does this really work? It looks like you deleted all the symbols but you still have relocations against the symbols you deleted.
Oops this file is supposed to be gone.  Eventually I just decided to check in the entire yaml files in all their glory.  They are suffixed with `-a` and `-b`.  This one was supposed to be removed.


https://reviews.llvm.org/D41718





More information about the llvm-commits mailing list